This repository has been archived by the owner on Jan 10, 2020. It is now read-only.
Exit process only when 'fail' config is enabled #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Grover is is no longer actively maintained. I think maybe I can help you if I'm permitted to push into the repository, but I lack authority unfortunately. |
|
@okuryu , can you ping anybody who has the right to merge this change. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is when another node module uses
groveras a dependency, and if that module invokesgrover.processmethod to run unit tests for a series of modules.The grover.process command exits the node process as soon as there are test failures in any of the modules which prevents from running the unit tests report for subsequent modules. The node process should exit only when
failconfig is enabled by the user.@caridy , @davglass . Please merge !!!