This repository has been archived by the owner on Jan 10, 2020. It is now read-only.
Fixed running tests on Windows #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests specified by an absolute path on the command line and tests that reference relative resources now work on Windows. Also fixed the path resolution of tests to work correctly when using the prefix and server options.
|
I am experiencing this issue as well, would be great to have this merged in! |
davglass
added a commit
that referenced
this pull request
Oct 25, 2013
Fixed running tests on Windows
|
Pushed in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had problems running tests on Windows that I've narrowed down to a simple test that includes a relative resource. For the
relative.htmltest in this patch before applying my fixes inoptions.jsI got the following results:This patch fixes these problems (with tests) and also fixes the path resolution of tests to work correctly when using the
--prefixand--serveroptions (previously the tests for these were failing in the1-args.jstest when run on Windows).These changes supersede #2, which didn't correctly handle absolute paths.