Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[debug] Increase retry times to wait MST device ready #12

Closed
wants to merge 1 commit into from

Conversation

yuazhe
Copy link
Owner

@yuazhe yuazhe commented Nov 13, 2024

The 10s waiting time is not enough occasionally, so increase it to 60s. Error message will be printed once exceed 10s so we can still detect this unnomal behavior even it get ready eventually.

Why I did it

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@yuazhe yuazhe changed the title Increase retry times to wait MST device ready [debug] Increase retry times to wait MST device ready Nov 14, 2024
The 10s waiting time is not enough occasionally, so increase it to 60s.
Error message will be printed once exceed 10s so we can still detect
this unnomal behavior even it get ready eventually.

Signed-off-by: Yuanzhe, Liu <[email protected]>
@ayurkiv-nvda
Copy link

hello @yuazhe
I suggest to change log severity from ERR to WARN (use LogWarn instead of LogError)
ERR is logs can cause unwanted alerts during running the tests from sonic-mgmt

@yuazhe
Copy link
Owner Author

yuazhe commented Nov 28, 2024

hello @yuazhe I suggest to change log severity from ERR to WARN (use LogWarn instead of LogError) ERR is logs can cause unwanted alerts during running the tests from sonic-mgmt

Intended to do so as this is a debug pr, the device was not supposed to be not ready for such long time, just want to find out how long exactly it's needed :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants