Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update cnos.rb #3256

Merged
merged 3 commits into from
Oct 2, 2024
Merged

update cnos.rb #3256

merged 3 commits into from
Oct 2, 2024

Conversation

robje
Copy link
Contributor

@robje robje commented Sep 4, 2024

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

  • The previous cnos.rb had configuration before version information, etc. Other modules we use, have version information, etc. before configuration. Section order changed
  • Also secrets were always deleted. With this PR the setting is respected.

@robertcheramy robertcheramy merged commit fea6647 into ytti:master Oct 2, 2024
5 checks passed
@robje robje deleted the update-cnos branch October 2, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robje @robertcheramy