Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opengear missing configuration fix #2881

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Opengear missing configuration fix #2881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b38994b
Fix for #2880 - opengear config not saved
ermuller Jul 21, 2023
a5252af
Add serial number collection for Opengear
ermuller Jul 21, 2023
ec27fac
Merge branch 'master' into opengear-config-2880
aschaber1 Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,14 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
## Added
- model for D-Link cisco like CLI (@mirackle-spb)
- model for Ruijie Networks RGOS devices (@spike77453)
- Add serial number collection to Opengear (@ermuller)
- added support for AricentISS 2.x firmware (@davromaniak)
- model for Asterfusion Network Operating System (@avl-dev)
- pagination for http source (@davama)
- model for Ericsson Miniling 6600 series (@schouwenburg)
- model for Mimosa B11 (@ritzbhuj)
+ Added ability to send mail with the Docker container
+ Documentation to send mail with hooks
- Added ability to send mail with the Docker container
- Documentation to send mail with hooks

## Changed
- tp-link: fixed enable mode post login entrance (@mirackle-spb)
Expand All @@ -33,6 +34,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
- fixed new date/time format with newer RouterOS `# jun/01/2023 12:11:25 by RouterOS 7.9.1` vs `# 2023-06-01 12:16:16 by RouterOS 7.10rc1` (@tim427)
- fixed netscaler backups with hostname set #2828 (@electrocret)
- Do not redirect stderr when fetching opnsense version since default shell (csh) doesn't support it (@spike77453)
- Fix missing configuration for Opengear (@ermuller)
- Fixed fan RPM speeds included in Aruba CX diffs (@danpoltawski)
- Gitcrypt output refinements (@electrocret)
- Remove constantly updating dates from backup of Adtran config (@davesbell)
Expand Down
13 changes: 12 additions & 1 deletion lib/oxidized/model/opengear.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,18 @@

cmd('cat /etc/version') { |cfg| comment cfg }

cmd('config -g config') { |cfg| cfg }
cmd 'showserial' do |cfg|
cfg.gsub! /^/, 'Serial Number: '
comment cfg
end

cmd 'config -g config' do |cfg|
out=''

Check warning on line 22 in lib/oxidized/model/opengear.rb

View workflow job for this annotation

GitHub Actions / test (3.0) 

[rubocop] reported by reviewdog 🐶
Surrounding space missing for operator `=`.

Raw Output:
lib/oxidized/model/opengear.rb:22:8: C: Layout/SpaceAroundOperators: Surrounding space missing for operator `=`.

Check warning on line 22 in lib/oxidized/model/opengear.rb

View workflow job for this annotation

GitHub Actions / test (3.1) 

[rubocop] reported by reviewdog 🐶
Surrounding space missing for operator `=`.

Raw Output:
lib/oxidized/model/opengear.rb:22:8: C: Layout/SpaceAroundOperators: Surrounding space missing for operator `=`.

Check warning on line 22 in lib/oxidized/model/opengear.rb

View workflow job for this annotation

GitHub Actions / test (3.2) 

[rubocop] reported by reviewdog 🐶
Surrounding space missing for operator `=`.

Raw Output:
lib/oxidized/model/opengear.rb:22:8: C: Layout/SpaceAroundOperators: Surrounding space missing for operator `=`.
cfg.each_line do |line|
out << line
end
out

Check warning on line 26 in lib/oxidized/model/opengear.rb

View workflow job for this annotation

GitHub Actions / test (3.0) 

[rubocop] reported by reviewdog 🐶
Inconsistent indentation detected.

Raw Output:
lib/oxidized/model/opengear.rb:26:4: C: Layout/IndentationConsistency: Inconsistent indentation detected.

Check warning on line 26 in lib/oxidized/model/opengear.rb

View workflow job for this annotation

GitHub Actions / test (3.1) 

[rubocop] reported by reviewdog 🐶
Inconsistent indentation detected.

Raw Output:
lib/oxidized/model/opengear.rb:26:4: C: Layout/IndentationConsistency: Inconsistent indentation detected.

Check warning on line 26 in lib/oxidized/model/opengear.rb

View workflow job for this annotation

GitHub Actions / test (3.2) 

[rubocop] reported by reviewdog 🐶
Inconsistent indentation detected.

Raw Output:
lib/oxidized/model/opengear.rb:26:4: C: Layout/IndentationConsistency: Inconsistent indentation detected.
end

cfg :ssh do
exec true # don't run shell, run each command in exec channel
Expand Down
Loading