Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix unit handling for np.take and unyt_array.take #551

Merged
merged 11 commits into from
Dec 25, 2024

Conversation

kyleaoman
Copy link
Contributor

Closes #549

Wasn't quite sure where to put some bits of this so might make sense to move things around a bit.

@kyleaoman
Copy link
Contributor Author

pre-commit.ci autofix

Copy link
Member

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this ! the logic is sound, I just have a couple suggestions

unyt/_array_functions.py Outdated Show resolved Hide resolved
unyt/_array_functions.py Outdated Show resolved Hide resolved
unyt/_array_functions.py Outdated Show resolved Hide resolved
unyt/array.py Outdated Show resolved Hide resolved
unyt/array.py Outdated Show resolved Hide resolved
unyt/tests/test_array_functions.py Outdated Show resolved Hide resolved
unyt/tests/test_array_functions.py Outdated Show resolved Hide resolved
@kyleaoman
Copy link
Contributor Author

pre-commit.ci autofix

@neutrinoceros neutrinoceros changed the title Implement take BUG: fix unit handling for np.take and unyt_array.take Dec 25, 2024
@neutrinoceros neutrinoceros added the bug Something isn't working label Dec 25, 2024
@neutrinoceros neutrinoceros merged commit d78655f into yt-project:main Dec 25, 2024
9 checks passed
@neutrinoceros neutrinoceros added this to the 3.0.4 milestone Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: numpy function take strips units with scalar index input
2 participants