[DeepL] Implement web API fallback #428
Conversation
| Language("es", "Spanish"), | ||
| Language("sv", "Swedish"), | ||
| Language("tr", "Turkish"), | ||
| Language("uk", "Ukrainian") |
There was a problem hiding this comment.
Where did you extract these languages from? The website? It'd be nice to add a comment here so that future people know where to look when updating the supported languages.
| "Sec-Fetch-Dest: empty", | ||
| "Sec-Fetch-Mode: cors", | ||
| "Sec-Fetch-Site: none", | ||
| "User-Agent: DeepLBrowserExtension/1.18.0 Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36" |
There was a problem hiding this comment.
Please move the user agent string to a constant, it will probably change in the future and thus we should place it in a different variable for ease of updating.
| "Sec-Fetch-Site: none", | ||
| "User-Agent: DeepLBrowserExtension/1.18.0 Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36" | ||
| ) | ||
| @POST("jsonrpc?client=chrome-extension,1.18.0") |
There was a problem hiding this comment.
Please move the version (1.18.0) to a constant and re-use for the user agent as commented above.
| "\"method\":\"", | ||
| // The random ID determines the spacing to use, do NOT change it | ||
| if ((id + 3) % 13 == 0 || (id + 5) % 29 == 0) { | ||
| "\"method\" : \"" | ||
| } else "\"method\": \"" |
There was a problem hiding this comment.
What's the source / reasoning for this magic stuff here?
|
Your feedback was taken into account and I rebased/merged commits. Note that it's usually not necessary to bump extension version/user agent, as you can see in other projects they have older versions, because old versions still work and bumping would require a review of other stuff than just changing the user agent, to be sure that nothing else changed in new versions that would prevent the API from working. Also, it would be best to disable automatic translation when the web version is used to avoid soft bans. This would result in the same situation of today where it doesn't work without an API key, but the whole point of this PR is to have a working anonymous (although less reliable) method :) An alternative would be to implement the web page API but it is more complex and more subject to client-side changes than the Chrome extension that is versioned ;) Some projects implement the two methods and the user can choose, but I will leave the second method to other contributors if interested ;) |
This adds a fallback to the DeepL engine, when no API key has been defined.
It emulates a request made through a browser, as seen in similar translation projects/libraries.
The downside is that it requires a reasonable delay between requests, otherwise you get a soft ban. It works fine when you disable automatic translation, but I didn't find a way to force users to have it (probably also needs to disable simultaneous translation?) when API key is not set.