Skip to content

Commit

Permalink
Modal Search Continued (plausible#4326)
Browse files Browse the repository at this point in the history
* update changelog

* remove redundant noop

* capitalize changelog entry
  • Loading branch information
RobertJoonas authored Jul 9, 2024
1 parent 795e137 commit 8c62346
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ All notable changes to this project will be documented in this file.
## Unreleased

### Added
- Add a search functionality in all Details views, except for Goal Conversions, Countries, Regions, Cities and Google Search terms
- Icons for browsers plausible/analytics#4239
- Automatic custom property selection in the dashboard Properties report
- Add `does_not_contain` filter support to dashboard
Expand Down
3 changes: 1 addition & 2 deletions assets/js/dashboard/stats/reports/list.js
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,6 @@ export default function ListReport(props) {

function renderBarFor(listItem) {
const lightBackground = props.color || 'bg-green-50'
const noop = () => { }
const metricToPlot = metrics.find(metric => metric.meta.plot).key

return (
Expand All @@ -254,7 +253,7 @@ export default function ListReport(props) {
<FilterLink
query={props.query}
filterInfo={props.getFilterFor(listItem)}
onClick={props.onClick || noop}
onClick={props.onClick}
extraClass="max-w-max w-full flex items-center md:overflow-hidden"
>
{maybeRenderIconFor(listItem)}
Expand Down

0 comments on commit 8c62346

Please sign in to comment.