Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

クリップをActivityPub拡張表現で扱う #617

Draft
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Jan 16, 2025

What

Why

resolve: #471

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link
Contributor

github-actions bot commented Jan 16, 2025

이 PR에 의한 api.json 차이
차이점이 없습니다.
Get diff files from Workflow Page

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 9.13462% with 189 lines in your changes missing coverage. Please review.

Project coverage is 38.39%. Comparing base (19a0caf) to head (f98b276).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ges/backend/src/server/ActivityPubServerService.ts 3.09% 188 Missing ⚠️
.../backend/src/core/activitypub/ApRendererService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #617      +/-   ##
===========================================
- Coverage    38.42%   38.39%   -0.03%     
===========================================
  Files         1694     1694              
  Lines       230493   230676     +183     
  Branches      3884     3885       +1     
===========================================
+ Hits         88568    88575       +7     
- Misses      141298   141434     +136     
- Partials       627      667      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913
Copy link
Collaborator Author

PeertubeがPlaylistとか生やしてるしrecommendCollectionsじゃなくて_yojoart_clipとかの方がいい気がする

@kozakura913
Copy link
Collaborator Author

recommendCollectionsにする

@kozakura913 kozakura913 added this to the 1.3.0 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApNoteCollection
1 participant