Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

グループ招待通知の修正 #607

Merged

Conversation

kozakura913
Copy link
Collaborator

What

Why

バグ修正

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@kozakura913 kozakura913 self-assigned this Jan 5, 2025
@kozakura913 kozakura913 added this to the 1.3.0 milestone Jan 5, 2025
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 38.44%. Comparing base (84f0f47) to head (41da0e2).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...end/src/core/entities/NotificationEntityService.ts 50.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #607      +/-   ##
===========================================
- Coverage    40.05%   38.44%   -1.62%     
===========================================
  Files         1696     1692       -4     
  Lines       235921   229906    -6015     
  Branches      3898     3866      -32     
===========================================
- Hits         94508    88376    -6132     
- Misses      140788   140865      +77     
- Partials       625      665      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 5, 2025

이 PR에 의한 api.json 차이
차이점이 없습니다.
Get diff files from Workflow Page

@kozakura913
Copy link
Collaborator Author

cherrypick4.14.0で修正済らしいからマージしないかも

@penginn-net
Copy link
Collaborator

cherrypick4.14.0で修正済らしいからマージしないかも

👀
kokonect-link/cherrypick@d23f4bf#diff-6b12325fc30c01a58739fd8d65bf301a8273878b54cf577028536679838e474aR101

deleteUserGroupInvitation干渉しそう?

@penginn-net
Copy link
Collaborator

penginn-net commented Jan 5, 2025

干渉はしないわdeleteInvitedNotificationだったCherryPick側のコードに置き換える?

@kozakura913
Copy link
Collaborator Author

干渉するだろうねー
そのコミットの変更だとこのプルリクで修正されるバグは修正されてないな

@kozakura913
Copy link
Collaborator Author

Cherrypick側優先の原則

@penginn-net
Copy link
Collaborator

今回でアップストリームマージ入れる?

@kozakura913
Copy link
Collaborator Author

入れたい

@kozakura913 kozakura913 merged commit 017fd61 into yojo-art:develop Jan 8, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants