Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

システムユーザーのファイル一覧を追加 #595

Merged
merged 5 commits into from
Dec 26, 2024

Conversation

kozakura913
Copy link
Collaborator

What

システムユーザー所有のファイルで絞り込みできるように設定を追加
絵文字に使われてるファイルにラベルを表示

Why

resolve: #484

Additional info (optional)

既存の「ファイル」の所に追加する感じで実装した

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.07%. Comparing base (db1709a) to head (68b58c7).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...kend/src/server/api/endpoints/admin/drive/files.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #595       +/-   ##
============================================
+ Coverage    19.87%   62.07%   +42.19%     
============================================
  Files          797      899      +102     
  Lines       123110   112828    -10282     
  Branches      1041     2856     +1815     
============================================
+ Hits         24474    70039    +45565     
+ Misses       98031    42729    -55302     
+ Partials       605       60      -545     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 25, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -6589,7 +6589,8 @@
                     "enum": [
                       "combined",
                       "local",
-                      "remote"
+                      "remote",
+                      "system"
                     ],
                     "default": "local"
                   },

Get diff files from Workflow Page

@kozakura913
Copy link
Collaborator Author

絵文字ラベル表示だけ別PRに移動させるかも

@kozakura913
Copy link
Collaborator Author

絵文字ラベルやっぱ別機能だしPR分けるわ

@kozakura913 kozakura913 merged commit 595cd94 into yojo-art:develop Dec 26, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

システムユーザーのファイル一覧
2 participants