Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

公開投稿以外の配送を制限する機能 #574

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from

Conversation

kozakura913
Copy link
Collaborator

What

publicとhome以外のnoteとrenoteを配送しない機能を追加

Why

resolve: #349

Additional info (optional)

ダイレクトは通しても良いかも?
通常投稿以外は対象にしてないけど他に非公開な要素あったっけ?

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 33.11258% with 101 lines in your changes missing coverage. Please review.

Project coverage is 40.08%. Comparing base (4545019) to head (bdbc2eb).

Files with missing lines Patch % Lines
.../api/endpoints/admin/federation/update-instance.ts 6.66% 28 Missing ⚠️
packages/frontend/src/scripts/get-user-menu.ts 0.00% 20 Missing ⚠️
...nd/src/queue/processors/DeliverProcessorService.ts 53.84% 18 Missing ⚠️
packages/backend/src/core/QueueService.ts 15.00% 17 Missing ⚠️
packages/frontend/src/pages/instance-info.vue 0.00% 12 Missing ⚠️
...ackages/frontend/src/pages/admin/modlog.ModLog.vue 0.00% 3 Missing ⚠️
packages/backend/src/queue/types.ts 0.00% 2 Missing ⚠️
...backend/src/core/entities/InstanceEntityService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #574       +/-   ##
============================================
+ Coverage    19.65%   40.08%   +20.42%     
============================================
  Files          797     1696      +899     
  Lines       122897   235818   +112921     
  Branches      1043     3949     +2906     
============================================
+ Hits         24152    94521    +70369     
- Misses       98138   140632    +42494     
- Partials       607      665       +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 18, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -10241,6 +10241,9 @@
                   },
                   "moderationNote": {
                     "type": "string"
+                  },
+                  "isQuarantineLimit": {
+                    "type": "boolean"
                   }
                 },
                 "required": [
@@ -88739,6 +88742,9 @@
               "string",
               "null"
             ]
+          },
+          "isQuarantineLimited": {
+            "type": "boolean"
           }
         },
         "required": [
@@ -88766,7 +88772,8 @@
           "faviconUrl",
           "themeColor",
           "infoUpdatedAt",
-          "latestRequestReceivedAt"
+          "latestRequestReceivedAt",
+          "isQuarantineLimited"
         ]
       },
       "GalleryPost": {

Get diff files from Workflow Page

@penginn-net
Copy link
Collaborator

penginn-net commented Dec 26, 2024

ノート作成時点でAPIエラー出して欲しいかも
ダイレクトは特に

@penginn-net
Copy link
Collaborator

機能の主目的はゆるい配送停止なのよねと言うのはある

@kozakura913
Copy link
Collaborator Author

ダイレクトの複数宛先で一部引っかかってエラーで送れなくなると困る

@penginn-net
Copy link
Collaborator

別の手段を取るか連合経由の公開範囲限定投稿で使うなとか言われたらそれはそうとしか言えないけど

伝えたつもりが伝わってないは使う時に困る

エラーにどのメンションがだめとか含めて返すは?

@kozakura913
Copy link
Collaborator Author

すべてのメンション(返信含む)の宛先に制限インスタンスがあれば該当したメンションのリストを返すか

@kozakura913
Copy link
Collaborator Author

サーバーブロックしてDM飛ばしたら普通にクライアントに通知することなく捨てられてたから現状の実装と変わらん

@penginn-net
Copy link
Collaborator

あーたしかに

@kozakura913
Copy link
Collaborator Author

テスト追加したい

@kozakura913
Copy link
Collaborator Author

blockも知られたくないしblockも配送止める

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

隔離されたインスタンス
2 participants