Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:SerchableByが未設定の時にプライバシーを更新できないことがある #567

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

penginn-net
Copy link
Collaborator

What

Fix #546 予定

Why

#546

Additional info (optional)

動作未確認なのでドラフト

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@penginn-net penginn-net added this to the yojo1.2.0 milestone Dec 9, 2024
@penginn-net penginn-net self-assigned this Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -50816,13 +50816,18 @@
                     "type": "boolean"
                   },
                   "searchableBy": {
-                    "type": "string",
+                    "type": [
+                      "string",
+                      "null"
+                    ],
                     "enum": [
                       "public",
                       "followersAndReacted",
                       "reactedOnly",
-                      "private"
-                    ]
+                      "private",
+                      null
+                    ],
+                    "description": "検索許可SearchableByの値を指定しますデフォルトはnull(isIndexableを参照)"
                   },
                   "hideOnlineStatus": {
                     "type": "boolean"

Get diff files from Workflow Page

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.95%. Comparing base (869c8cf) to head (4c5def8).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #567       +/-   ##
============================================
+ Coverage    19.88%   39.95%   +20.06%     
============================================
  Files          797     1696      +899     
  Lines       122905   235681   +112776     
  Branches      1041     3931     +2890     
============================================
+ Hits         24439    94161    +69722     
- Misses       97861   140853    +42992     
- Partials       605      667       +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penginn-net penginn-net marked this pull request as ready for review December 13, 2024 05:54
@kozakura913
Copy link
Collaborator

テスト環境で動いた

@penginn-net penginn-net merged commit e03bfa3 into yojo-art:develop Dec 20, 2024
34 of 35 checks passed
@penginn-net penginn-net deleted the fix-546 branch December 20, 2024 08:50
@kozakura913 kozakura913 mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

プライバシー設定を保存できない事がある
2 participants