Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: outboxFetch(キャッシュが正しく使われない、型定義) #560

Merged
merged 6 commits into from
Dec 20, 2024

Conversation

penginn-net
Copy link
Collaborator

What

Why

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@penginn-net penginn-net added this to the yojo1.2.0 milestone Nov 30, 2024
@penginn-net penginn-net self-assigned this Nov 30, 2024
@penginn-net penginn-net changed the title Fix: utboxFetch(キャッシュが正しく使われない、型定義) Fix: outboxFetch(キャッシュが正しく使われない、型定義) Nov 30, 2024
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 25.86207% with 43 lines in your changes missing coverage. Please review.

Project coverage is 38.47%. Comparing base (869c8cf) to head (9a9cfd2).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...rc/core/activitypub/models/ApOutboxFetchService.ts 3.22% 30 Missing ⚠️
.../backend/src/core/activitypub/ApResolverService.ts 21.42% 11 Missing ⚠️
...ackend/src/server/api/endpoints/ap/fetch-outbox.ts 83.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #560       +/-   ##
============================================
+ Coverage    19.88%   38.47%   +18.59%     
============================================
  Files          797     1692      +895     
  Lines       122905   229503   +106598     
  Branches      1041     3864     +2823     
============================================
+ Hits         24439    88311    +63872     
- Misses       97861   140527    +42666     
- Partials       605      665       +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 30, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -21595,6 +21595,24 @@
                       }
                     }
                   },
+                  "OUTBOX_PART_IS_INVALID": {
+                    "value": {
+                      "error": {
+                        "message": "outbox part is invalid",
+                        "code": "OUTBOX_PART_IS_INVALID",
+                        "id": "c3e584df-068a-4b1d-967e-54f2f30f7cba"
+                      }
+                    }
+                  },
+                  "OUTBOX_ITEM_IS_UNAVAILABLE": {
+                    "value": {
+                      "error": {
+                        "message": "outbox item is unavailable",
+                        "code": "OUTBOX_ITEM_IS_UNAVAILABLE",
+                        "id": "a07b05af-5f66-4203-918c-ebff9e9384bf"
+                      }
+                    }
+                  },
                   "INVALID_PARAM": {
                     "value": {
                       "error": {

Get diff files from Workflow Page

@penginn-net penginn-net marked this pull request as draft November 30, 2024 14:57
@penginn-net penginn-net marked this pull request as ready for review December 3, 2024 04:43
@kozakura913
Copy link
Collaborator

だいぶ綺麗になったね

@penginn-net penginn-net merged commit add720a into yojo-art:develop Dec 20, 2024
31 of 33 checks passed
@kozakura913 kozakura913 mentioned this pull request Dec 20, 2024
@penginn-net penginn-net deleted the fix-duplicate-file branch December 21, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants