-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ノートを編集する時に検索許可範囲を記憶する #558
Merged
kozakura913
merged 6 commits into
yojo-art:develop
from
kozakura913:fix_searchableby_frontend
Nov 29, 2024
Merged
ノートを編集する時に検索許可範囲を記憶する #558
kozakura913
merged 6 commits into
yojo-art:develop
from
kozakura913:fix_searchableby_frontend
Nov 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/backend
packages/frontend
packages/cherrypick-js
labels
Nov 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #558 +/- ##
===========================================
+ Coverage 38.49% 40.08% +1.59%
===========================================
Files 1691 1695 +4
Lines 229401 235598 +6197
Branches 3878 3896 +18
===========================================
+ Hits 88304 94437 +6133
- Misses 140472 140496 +24
- Partials 625 665 +40 ☔ View full report in Codecov by Sentry. |
이 PR에 의한 api.json 차이 차이점은 여기에서 볼 수 있음--- base
+++ head
@@ -86471,6 +86471,18 @@
"specified"
]
},
+ "searchableBy": {
+ "type": [
+ "string",
+ "null"
+ ],
+ "enum": [
+ "public",
+ "private",
+ "followersAndReacted",
+ "reactedOnly"
+ ]
+ },
"mentions": {
"type": "array",
"items": {
@@ -86691,6 +86703,7 @@
"userId",
"user",
"visibility",
+ "searchableBy",
"reactionAcceptance",
"reactionEmojis",
"reactions", |
penginn-net
approved these changes
Nov 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#553
Why
Fix: #553
Additional info (optional)
Checklist