Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ノートを編集する時に検索許可範囲を記憶する #558

Merged
merged 6 commits into from
Nov 29, 2024

Conversation

kozakura913
Copy link
Collaborator

What

#553

Why

Fix: #553

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 40.08%. Comparing base (a037a66) to head (dbd7ce9).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...kages/frontend/src/components/MkPostFormSimple.vue 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #558      +/-   ##
===========================================
+ Coverage    38.49%   40.08%   +1.59%     
===========================================
  Files         1691     1695       +4     
  Lines       229401   235598    +6197     
  Branches      3878     3896      +18     
===========================================
+ Hits         88304    94437    +6133     
- Misses      140472   140496      +24     
- Partials       625      665      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 27, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음
--- base
+++ head
@@ -86471,6 +86471,18 @@
               "specified"
             ]
           },
+          "searchableBy": {
+            "type": [
+              "string",
+              "null"
+            ],
+            "enum": [
+              "public",
+              "private",
+              "followersAndReacted",
+              "reactedOnly"
+            ]
+          },
           "mentions": {
             "type": "array",
             "items": {
@@ -86691,6 +86703,7 @@
           "userId",
           "user",
           "visibility",
+          "searchableBy",
           "reactionAcceptance",
           "reactionEmojis",
           "reactions",

Get diff files from Workflow Page

@kozakura913 kozakura913 marked this pull request as ready for review November 29, 2024 05:50
@kozakura913 kozakura913 self-assigned this Nov 29, 2024
@kozakura913 kozakura913 added this to the yojo1.2.0 milestone Nov 29, 2024
@kozakura913 kozakura913 changed the title 検索許可範囲を記憶する ノートを編集する時に検索許可範囲を記憶する Nov 29, 2024
@kozakura913 kozakura913 merged commit f918b11 into yojo-art:develop Nov 29, 2024
36 of 37 checks passed
@kozakura913 kozakura913 mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ノートを編集する時に検索許可範囲が維持されない
2 participants