Skip to content

Commit

Permalink
Ensure correct custom SSL certificate passed in connection string.pga…
Browse files Browse the repository at this point in the history
  • Loading branch information
yogeshmahajan-1903 committed Dec 4, 2024
1 parent 4392b83 commit 80161c3
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
6 changes: 5 additions & 1 deletion web/pgadmin/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -829,7 +829,7 @@ def before_request():
# but the user session may still be active. Logout the user
# to get the key again when login
if config.SERVER_MODE and current_user.is_authenticated and \
app.PGADMIN_EXTERNAL_AUTH_SOURCE not in [
session['auth_source_manager']['current_source'] not in [
KERBEROS, OAUTH2, WEBSERVER] and \
current_app.keyManager.get() is None and \
request.endpoint not in ('security.login', 'security.logout'):
Expand Down Expand Up @@ -915,6 +915,10 @@ def all_exception_handler(e):
@app.errorhandler(HTTPException)
def http_exception_handler(e):
current_app.logger.error(e, exc_info=True)
if e.code == 400 and\
e.description == 'The CSRF session token is missing.':
error = str(e.description) + 'Please refresh the page.'
return internal_server_error(errormsg=gettext(error))
return e

# Intialize the key manager
Expand Down
6 changes: 2 additions & 4 deletions web/pgadmin/utils/driver/psycopg3/server_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -673,13 +673,11 @@ def create_connection_string(self, database, user, password=None):
orig_value = value
# Getting complete file path if the key is one of the below.
if key in ['passfile', 'sslcert', 'sslkey','sslcrl',
'sslcrldir']:
'sslcrldir'] or \
(key == 'sslrootcert' and value != 'system'):
with_complete_path = True
value = get_complete_file_path(value)

if key == 'sslrootcert' and value != 'system':
dsn_args[key] = get_complete_file_path(value)

# If key is hostaddr and ssh tunnel is in use don't overwrite.
if key == 'hostaddr' and self.use_ssh_tunnel:
continue
Expand Down

0 comments on commit 80161c3

Please sign in to comment.