Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 9 compatibility fixes. #8

Open
wants to merge 4 commits into
base: 9.x-2.x
Choose a base branch
from
Open

Conversation

NightHunterSV
Copy link

No description provided.

@froboy
Copy link

froboy commented Jan 7, 2022

@NightHunterSV I've tested pieces of this on a site and while there's a lot i haven't tested, there's one change necessary.

$duration = $form_state->getValue(['duration', 0, 'value']);

should be

    $duration = $form_state->getValue(['duration', 0, 'duration']);

Otherwise the Edit/Add form for playlist items at admin/digital-signage/playlist/__/edit will not save.

@froboy
Copy link

froboy commented Jan 7, 2022

Also

throws an error: Call to a member function addClass() on array ...

so just above it (line 120) should add:

  if (!($variables['attributes'] instanceof Attribute)) {
    $variables['attributes'] = new Attribute($variables['attributes']);
  }

@AndreyMaximov
Copy link
Contributor

@froboy thanks for your feedback. Those issues have been addressed, the fixes are incorporated in this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants