Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8
This fixes the ribbon issue by opting to use marks even for each line (not full line styling) which allows a nested span to be used.
The only case this doesn't work is on blank lines (CM6 ignores decorations on content if the line is blank) which are still treated as line marks. To get these to show you'll need to style them:
I tried a couple of other approaches where you use only line decorations and style only the children using a color variable, but that led to these cases:
Which felt wrong for my app. So I use the line based approach instead. Note: the style variable
--y-line-selection-color
is declared at each line so you can approach this with CSS in your own app.