Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ribbon selection for full lines #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeffrafter
Copy link

#8

This fixes the ribbon issue by opting to use marks even for each line (not full line styling) which allows a nested span to be used.

image

The only case this doesn't work is on blank lines (CM6 ignores decorations on content if the line is blank) which are still treated as line marks. To get these to show you'll need to style them:

 .cm-yLineSelection.cm-yLineSelection-empty {
  width: 12px;
}

I tried a couple of other approaches where you use only line decorations and style only the children using a color variable, but that led to these cases:

image

Which felt wrong for my app. So I use the line based approach instead. Note: the style variable --y-line-selection-color is declared at each line so you can approach this with CSS in your own app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant