-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
woff, woff2 for regular, italic, bold and bolditalic with scss changes for cayman #29
base: master
Are you sure you want to change the base?
Conversation
remove OpenSans regular and bold *.woff files. Add OpenSans regular, bold, italic and bold-italic as *.woff2
*.woff added again ... : )
scss for *.woff and *.woff2 with bold and boltitalic
`fonts/` directory in path added/fixed
Thanks for the patch. Note that the fonts are used by all themes, so I would suggest keeping the existing font files and use consistent file names for other newly added font faces. Also I'm not sure whether it is necessary to include both WOFF and WOFF2. I guess pandoc will include both files in the generated HTML document, making the output unnecessarily large. |
SO, css-tricks, caniuse, webfontsgoogle (api, css2) ... going for woff2 only is an viable option. therefore no *.woff Naming google-webfont-helper site. Which also shows we have the latin_extended ones.
changed the scss to target the new *.woff2 latin_extended Open Sans fonts.
Hi @yixuan, *.woff or *.woff2
naming schemeI use the naming scheme from google-webfonts-helper, but any other should do too. I read your comment on keeping existing font files, but that would add more file size mixing italic, bold-italic and latin-extendedThe Open Sans is a widely used font-family ... using the real italic and real bold-italic makes it better. changed scss for all themesI changed the corresponding scss-files to target the 4 I hope you can test this and hope it will meet your ideas, |
Cool! I'm a bit busy these days, but I'll look at the PR more carefully as soon as I get some time. |
woff and woff2 (latin-extended)
for regular, italic, bold and bolditalic with scss changes for cayman theme.
Perhaps you want to try this out.
thanks,
christoph