Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consent-mode & Popup #198

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Consent-mode & Popup #198

wants to merge 13 commits into from

Conversation

JustinElst
Copy link

This adds a consent popup/banner and lets Tag Manager know what the selected options are.

Have a look here how Tag Manager handles Consent:
https://support.google.com/tagmanager/answer/10718549

This addition is a bit early stages but for now it functions as it should.
The Luma theme frontend lacks any styling the Hyva version is quite complete.

This could be a separate addon-module as well, if it's out of scope of this one.

@JustinElst
Copy link
Author

@jissereitsma is this something you are willing to add?

@jissereitsma
Copy link
Collaborator

Sorry for the loooooooooooooooong delay. Yes, I'm definitely interested in this. However, I personally feel that it would be better to split this module off the main module. I'll check soon how this could be done.

@JustinElst
Copy link
Author

No problem! And splitting it might be the best solution here.
But it would require some work to integrate the two.... Let me know if you have any questions or need help with this!

@JustinElst
Copy link
Author

Ive also added a specific little feature (always on, so no config..) to another branch..
https://github.com/JustinElst/Yireo_GoogleTagManager2/tree/consent-airpress
This adds 'consent-events':

  • cookieConsentUpdate when consent is updated (user-interaction on consent modal)
  • cookieConsentInitial when consent is initialized (all pages)
  • cookieConsentGranted necessary is granted (always)
  • cookieConsentMarketingGranted marketing is granted
  • cookieConsentAnalyticsGranted analytics is granted
  • cookieConsentPreferencesGranted preferences is granted

With these events you can trigger tags that don't have 'consentMode'.
But this feature might be a seperate pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants