Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better performance for exists() method of Query class #291

Closed
wants to merge 0 commits into from

Conversation

ziaratban
Copy link
Contributor

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues #290

@samdark samdark added this to the 2.1.10 milestone Dec 27, 2019
src/Query.php Outdated Show resolved Hide resolved
@ziaratban
Copy link
Contributor Author

@samdark please set performance-query-exists to current PR.

@samdark
Copy link
Member

samdark commented Feb 15, 2020

@ziaratban what do you mean by "set performance-query-exists to current PR"? I can't change PR's branch.

@ziaratban
Copy link
Contributor Author

@ziaratban what do you mean by "set performance-query-exists to current PR"? I can't change PR's branch.

i removed commit from master branch and me create a new branch for this PR. because this commit show in all my PR.

seems i must be create a new PR.

thanks.

@samdark
Copy link
Member

samdark commented Feb 16, 2020

Yes. Start with a new branch from clean master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants