Cycle orm migrations #25

roxblnfk · 2019-10-15T17:13:12Z

Q	A
Is bugfix?	❌
New feature?	✔️
Breaks BC?	❌
Tests pass?	no test
Fixed issues	#23

Added new commands:

  migrate/generate  Generates a migration
  migrate/up        Execute all new migrations
  migrate/down      Rollback last migration
  migrate/list      Print list of all migrations

Note: exec `hiqdev\composer\config\Builder::rebuild();` or `composer install` for configs rebuilding

config/common.php

Added option for singular naming in table names (in migrations and in syncschema)

- EntityFinderHelper renamed to CycleOrmHelper (some code now here); - ORM Schema now cached; - UserRepository now extends Cycle\ORM\Select\Repository Fixed: - Yiisoft\..\CacheInterface initialization

roxblnfk · 2019-10-18T18:13:41Z

Now i'm satisfied. Please let's review this

samdark · 2019-10-21T08:47:01Z

src/Console/Migration/.gitignore

@@ -0,0 +1 @@
+!.gitignore


How about moving migrations out of src/Console? These could be treated as non-source i.e. be in the migrations at the top level or at least could be moved out of Console.

Maybe you're right. In addition, I also wanted to make a drop cache when applying / rolling back migrations

About the location of the migrations:
Migrations change (add) with Entities. I think they have the right to be in Src along with Entities

OK but, I think, not in Console.

src/Migration ?

samdark · 2019-10-21T08:59:31Z

@roxblnfk I've pushed some minor adjustments. Overall looks good for me except where migrations are located.

samdark · 2019-10-21T10:45:08Z

src/Console/Command/MigrateGenerate.php

+
+    protected function execute(InputInterface $input, OutputInterface $output)
+    {
+        $this->cycleHelper->generateMigration($this->migrator, $this->config);


@wolfy-j suggested that such check is needed.

Cycle will generate migrations based on diff with current DB schema if the schema is not consistent you will generate broken migrations. This is a small nasty issue, so such check is recommended.

I understand and support this recommendation. Also, it would be nice not to generate empty migrations

Hmm... Why would empty migrations be generated?

We are checking if migration is required via Generator observer: https://github.com/spiral/framework/blob/master/src/Command/Cycle/MigrateCommand.php#L78

You are free to copy its code, it also gives you a nice description of what have changed.

https://github.com/spiral/framework/blob/master/src/Command/Cycle/Generator/ShowChanges.php

ref cycle/migrations#4

Fixed in 1.0.5

One question. How would it work if you write migration manually? Would that still create dummy migration classes for me?

ORM and manual migrations works using the same engine, you can combine them if you want. Basically ORM simply writes migrations for you, the rest is the same.

https://github.com/cycle/migrations/blob/master/src/GenerateMigrations.php#L87

wolfy-j · 2019-10-21T17:02:34Z

I would recommend a way to add empty migration manually. There are always cases where you can't rely on ORM to solve diff.

roxblnfk · 2019-10-21T18:58:49Z

I would recommend a way to add empty migration manually. There are always cases where you can't rely on ORM to solve diff.

Then you will have to change the code again, because now using \Cycle\Migrations\GenerateMigrations you can not create empty migrations

wolfy-j · 2019-10-21T19:02:22Z

You can not create empty relations for ORM, you still can create migrations directly. Migrator and ORM/Migrations are two different packages.

That's how you can register migration:
https://github.com/cycle/migrations/blob/master/src/GenerateMigrations.php#L87

And that's how you can generate empty one:
https://github.com/cycle/migrations/blob/master/src/GenerateMigrations.php#L117

We have a command which allows us to scaffold migrations with some tables and columns pre-defined (without orm).

roxblnfk · 2019-10-21T19:06:08Z

@wolfy-j I just want to avoid code duplication

wolfy-j · 2019-10-21T19:08:34Z

Well, you can always use a string body like a classic template. I'm just saying that empty/user migration is nothing more than just a class in migrations directory.

roxblnfk · 2019-10-21T19:28:23Z

I'm just saying that empty/user migration is nothing more than just a class in migrations directory.

Yes, that’s obvious. That is why it is useful to check for unapplied migrations before generating new ones. Because if you do not apply the previously generated migration, the new migration will take the all unapplied changes

roxblnfk · 2019-10-23T11:07:04Z

All code migrated to yiisoft/yii-cycle#1

roxblnfk added 5 commits October 15, 2019 15:13

Added consoled command migrate/generate

67c26f2

Added consoled command migrate/up

bc7eb85

Added consoled command migrate/down

8491f2b

Added consoled command migrate/list

fc48834

Cleanup;

533c3e3

Note: exec `hiqdev\composer\config\Builder::rebuild();` or `composer install` for configs rebuilding

roxblnfk force-pushed the cycle-orm-migrations branch from 62d2b5e to c25ad33 Compare October 15, 2019 17:22

Style fix

e0ec67a

roxblnfk force-pushed the cycle-orm-migrations branch from c25ad33 to e0ec67a Compare October 15, 2019 17:25

samdark added type:feature New feature status:code review The pull request needs review. labels Oct 15, 2019

samdark reviewed Oct 16, 2019

View reviewed changes

config/common.php Outdated Show resolved Hide resolved

roxblnfk added 3 commits October 18, 2019 18:07

Decided two todos in common.php - added EntityFinderHelper class;

0147b88

Added option for singular naming in table names (in migrations and in syncschema)

Refactoring:

1b9f6ed

- EntityFinderHelper renamed to CycleOrmHelper (some code now here); - ORM Schema now cached; - UserRepository now extends Cycle\ORM\Select\Repository Fixed: - Yiisoft\..\CacheInterface initialization

Code style hotfix

0d036f8

samdark added 5 commits October 21, 2019 11:33

Fix formatting [skip ci]

7690e6a

Fix formatting [skip ci]

a82a41b

Fix formatting

80817b4

Remove unneeded imports

c2563c7

Add missing return types

f8a7b79

samdark reviewed Oct 21, 2019

View reviewed changes

samdark removed the status:code review The pull request needs review. label Oct 21, 2019

Drop cached schema when migration up/down

e84e78d

samdark reviewed Oct 21, 2019

View reviewed changes

added checking unapplied migrations

e1e929f

roxblnfk closed this Oct 23, 2019

rossaddison mentioned this pull request Jun 12, 2021

Error: Call to protected Yiisoft\Validator\Rule::__construct() from context 'App\Blog\Post\PostForm' #311

Closed

rossaddison mentioned this pull request Jul 19, 2021

Introducing any new Entity file into Entity folder creating error: Cycle\Annotated\Exception\AnnotationException: #325

Closed

rossaddison mentioned this pull request Sep 27, 2021

Minor issue: Temporary Solution: 1709 Index column size too large .Max column size is 767 bytes: mySql 5.7.31 to mySql 8.0.26: #358

Closed

rossaddison mentioned this pull request Jan 26, 2022

Assigning admin role to first user 1 using console creates Type Error: c:\>yii 'user/assignRole' admin 1 #433

Closed

rossaddison mentioned this pull request Apr 16, 2022

./yii fixture/add console command not working #439

Closed

rossaddison mentioned this pull request Oct 4, 2022

TypeError Cannot assign Cycle\ORM\Reference\Reference to property App\Invoice\Entity\Quote::$client of type ?App\Invoice\Entity\Client #510

Closed

rossaddison mentioned this pull request Nov 8, 2022

No definition or class found or resolvable for "Yiisoft\Translator\MessageReaderInterface" while building "Yiisoft\Translator\MessageReaderInterface". #543

Closed

rossaddison mentioned this pull request Dec 12, 2022

Yiisoft\Di\NotFoundException No definition or class found or resolvable for "Yiisoft\Validator\RuleHandlerContainer" while building "Yiisoft\Validator\RuleHandlerContainer". #554

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cycle orm migrations #25

Cycle orm migrations #25

roxblnfk commented Oct 15, 2019

roxblnfk commented Oct 18, 2019

samdark Oct 21, 2019

roxblnfk Oct 21, 2019

roxblnfk Oct 21, 2019

samdark Oct 21, 2019

roxblnfk Oct 21, 2019

samdark commented Oct 21, 2019

samdark Oct 21, 2019

wolfy-j Oct 21, 2019

roxblnfk Oct 21, 2019

samdark Oct 21, 2019

wolfy-j Oct 21, 2019 •

edited

Loading

wolfy-j Oct 21, 2019

wolfy-j Oct 21, 2019

samdark Oct 21, 2019 •

edited

Loading

wolfy-j Oct 21, 2019

wolfy-j Oct 21, 2019

wolfy-j commented Oct 21, 2019

roxblnfk commented Oct 21, 2019

wolfy-j commented Oct 21, 2019 •

edited

Loading

roxblnfk commented Oct 21, 2019

wolfy-j commented Oct 21, 2019 •

edited

Loading

roxblnfk commented Oct 21, 2019

roxblnfk commented Oct 23, 2019

		@@ -0,0 +1 @@
		!.gitignore

Cycle orm migrations #25

Cycle orm migrations #25

Conversation

roxblnfk commented Oct 15, 2019

roxblnfk commented Oct 18, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samdark commented Oct 21, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wolfy-j Oct 21, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samdark Oct 21, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wolfy-j commented Oct 21, 2019

roxblnfk commented Oct 21, 2019

wolfy-j commented Oct 21, 2019 • edited Loading

roxblnfk commented Oct 21, 2019

wolfy-j commented Oct 21, 2019 • edited Loading

roxblnfk commented Oct 21, 2019

roxblnfk commented Oct 23, 2019

wolfy-j Oct 21, 2019 •

edited

Loading

samdark Oct 21, 2019 •

edited

Loading

wolfy-j commented Oct 21, 2019 •

edited

Loading

wolfy-j commented Oct 21, 2019 •

edited

Loading