Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor column PHP type #862

Merged
merged 10 commits into from
Aug 9, 2024
Merged

Refactor column PHP type #862

merged 10 commits into from
Aug 9, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Aug 8, 2024 •
edited
Loading

This was referenced Aug 8, 2024
Merged
Merged
Merged
@codecov Codecov
Copy link

codecov bot commented Aug 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.24561% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.61%. Comparing base (23e8d43) to head (19adfb4).

Files Patch % Lines
src/Schema/AbstractSchema.php 95.00% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             master     #862       +/-   ##
=============================================
+ Coverage     85.06%   99.61%   +14.54%     
- Complexity     1369     1372        +3     
=============================================
  Files            74       74               
  Lines          3369     3362        -7     
=============================================
+ Hits           2866     3349      +483     
+ Misses          503       13      -490

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Aug 8, 2024
Merged
Merged
@Tigrov Tigrov requested a review from vjik August 9, 2024 06:51
@Tigrov Tigrov added the status:code review The pull request needs review. label Aug 9, 2024
vjik
vjik approved these changes Aug 9, 2024
View reviewed changes
src/Constant/PhpType.php Outdated Show resolved Hide resolved
src/Constant/GettypeResult.php Outdated Show resolved Hide resolved
src/Schema/Column/ColumnSchemaInterface.php Show resolved Hide resolved
@Tigrov Tigrov merged commit 6a8ceea into master Aug 9, 2024
68 checks passed
@Tigrov Tigrov deleted the refactor-column-php-type branch August 9, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik vjik approved these changes

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tigrov @samdark @vjik @StyleCIBot