Improve psalm types for scalar values in select #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vjik
commented
Apr 7, 2024
vjik
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues | - |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## allow_scalars #818 +/- ##
====================================================
- Coverage 99.55% 87.44% -12.12%
Complexity 1278 1278
====================================================
Files 63 63
Lines 3129 3129
====================================================
- Hits 3115 2736 -379
- Misses 14 393 +379 ☔ View full report in Codecov by Sentry. |
vjik
added a commit
that referenced
this pull request
Apr 13, 2024
* Allow scalar values for `Query::select()` * Apply fixes from StyleCI * Apply Rector changes (CI) * Apply fixes from StyleCI * Update CHANGELOG.md and UPGRADE.md [skip ci] * Update CHANGELOG.md and UPGRADE.md [skip ci] * Update UPGRADE.md [skip ci] * Update UPGRADE.md [skip ci] * fix UPGRADE.md * improve `UPGRADE.md` * Improve psalm types for scalar values in select (#818) * Improve psalm types for scalar values in select * Remove unnecessary psalm annotations --------- Co-authored-by: Tigrov <[email protected]> * Improve phpdoc [skip ci] * Update tests/Provider/QueryBuilderProvider.php Co-authored-by: Sergei Predvoditelev <[email protected]> * Fix test * Add type string to test --------- Co-authored-by: StyleCI Bot <[email protected]> Co-authored-by: Tigrov <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.