Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return type of method is corrected. #814

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

MrWasimAbbasi
Copy link
Contributor

@MrWasimAbbasi MrWasimAbbasi commented Mar 23, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues code readability increased

Copy link

what-the-diff bot commented Mar 23, 2024

PR Summary

  • Modification of testSerialized Method in AbstractConnectionTest.php
    The testSerialized method has been updated to define the kind of value it returns. From now on, it's made clear that this function does not return any value, enhancing the predictability and readability of our codebase.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.51%. Comparing base (71c9f37) to head (170f1a0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #814      +/-   ##
============================================
- Coverage     99.55%   99.51%   -0.04%     
  Complexity     1277     1277              
============================================
  Files            63       63              
  Lines          3120     3120              
============================================
- Hits           3106     3105       -1     
- Misses           14       15       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit 749c3f3 into yiisoft:master Mar 25, 2024
79 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants