Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add psalm type for parameters to bind to the SQL statement #809

Merged
merged 3 commits into from
Feb 18, 2024
Merged

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 12, 2024

Q A
Is bugfix?
New feature?
Breaks BC?

Copy link

what-the-diff bot commented Feb 12, 2024

PR Summary

  • Enhanced SQL Statements
    The parameters associated with the SQL statements will now have specified types, making any interaction with our database more secure and efficient.
  • Augmented Interfaces
    Addition of variable $params in multiple key places within our code such as CommandInterface and ConnectionInterface allows for wider flexibility and clearer communication between various parts of our software.
  • Introduced ParamsType in Multiple Interfaces
    By introducing a new ParamsType in numerous interfaces, we have not only added a new layer of sophistication but also an additional check to ensure that the parameters passed are of the expected type.
  • Updated Methods in AbstractDMLQueryBuilder
    This update allows our AbstractDMLQueryBuilder to handle a variety of parameters, enhancing its flexibility and adaptability.
  • Updated Methods in DQLQueryBuilderInterface and QueryBuilderInterface
    The introduction of $params parameter to several methods improves our query building process, leading to cleaner codes and more readable queries.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (03dc434) 99.55% compared to head (f8d4841) 99.55%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #809   +/-   ##
=========================================
  Coverage     99.55%   99.55%           
  Complexity     1277     1277           
=========================================
  Files            63       63           
  Lines          3120     3120           
=========================================
  Hits           3106     3106           
  Misses           14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik marked this pull request as ready for review February 12, 2024 18:21
@vjik vjik requested a review from a team February 12, 2024 18:21
@vjik vjik added the status:code review The pull request needs review. label Feb 12, 2024
@vjik vjik merged commit db71c9a into master Feb 18, 2024
170 of 171 checks passed
@vjik vjik deleted the params-type branch February 18, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants