Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix psalm issues #802

Merged
merged 5 commits into from
Feb 3, 2024
Merged

Fix psalm issues #802

merged 5 commits into from
Feb 3, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jan 30, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@Tigrov Tigrov added the status:code review The pull request needs review. label Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef81e8b) 99.64% compared to head (c654a52) 99.64%.
Report is 1 commits behind head on master.

❗ Current head c654a52 differs from pull request most recent head fe8d87c. Consider uploading reports for the commit fe8d87c to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #802   +/-   ##
=========================================
  Coverage     99.64%   99.64%           
+ Complexity     1271     1270    -1     
=========================================
  Files            63       63           
  Lines          3106     3106           
=========================================
  Hits           3095     3095           
  Misses           11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Jan 30, 2024

PR Summary

  • Support for PHP version 8.3
    The workflow file has been updated to include support for PHP 8.3. This allows the use of this project with the latest version of PHP.

  • New Enhancement Recorded
    A new enhancement has been referenced in the project's change log. This provides users with updated information about the improvements made to the project.

  • Dependency Update
    The version of the vimeo/psalm dependency has been updated. This implies that our project now supports and benefits from the features of the new versions (^4.30|^5.20) of this dependency.

  • New Issue Handler
    A new issue handler called RiskyTruthyFalsyComparison has been added. This improves the project's error handling capability and aids in spotting specific issues quicker.

  • Code Refactoring
    Minor modifications were made to the normalize method used in the SchemaCache.php file. This means the code is now more efficient or easier to understand.

  • Code Modification for Null Coalescing Operator
    The AbstractPdoCommand.php file was adjusted to use the null coalescing operator. This aids in cleaner and more efficient handling of null values, reducing the risk of unexpected null errors.

  • Improved Handling of Empty $indexType Case
    The code in AbstractDDLQueryBuilder.php has been modified to better handle cases when $indexType is empty. This change reduces the chance of running into issues when $indexType value is not present.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It remains is adding a line to changelog.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Sergei Predvoditelev <[email protected]>
@vjik vjik merged commit 4a08ca3 into master Feb 3, 2024
3 checks passed
@vjik vjik deleted the fix-psalm-issues branch February 3, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants