Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate $withColumn argument of Quoter::getTableNamesParts() #768

Merged

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 1, 2023

Deprecate $withColumn argument of Quoter::getTableNamesParts() method

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues #757

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (39872b1) 99.05% compared to head (adbafeb) 99.05%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #768   +/-   ##
=========================================
  Coverage     99.05%   99.05%           
  Complexity     1260     1260           
=========================================
  Files            67       67           
  Lines          3059     3059           
=========================================
  Hits           3030     3030           
  Misses           29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Nov 1, 2023

PR Summary

  • Update in QuoterInterface.php file
    This update pertains to a particular file entitled 'QuoterInterface.php'.
  • Deprecation Notice on 'withColumn' Parameter
    The component known as 'withColumn' in the 'splitTableName()' method is labeled as deprecated. This implies it's scheduled to be discontinued or removed in the upcoming 2.0.0 version of our software.

@vjik vjik merged commit b92cf1d into master Nov 9, 2023
166 of 167 checks passed
@vjik vjik deleted the deprecate-Quoter-getTableNamesParts-withColumn-argument branch November 9, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants