Different tables in columns

[Tigrov]

What is the correct behavior?

1. Filter columns from other tables
2. Let them be in the query

The test example is about the code:

$table = '{{%type}}';
$columns = ['{{%type}}.[[bool_col]]', '{{%another_table}}.[[bool_col2]]'];
$values = [[true, false]];

$command->batchInsert($table, $columns, $values);

// INSERT INTO {{%type}} ([[bool_col]], [[bool_col2]]) VALUES (:qp0, :qp1)

The same for methods batchInsert(), insert(), update(), upsert()

[what-the-diff]

PR Summary

• New Test Case Added
  A new test case "different tables in columns" has been added to the tests/Provider/QueryBuilderProvider.php file. This helps verify and ensure that data gets correctly inserted into different columns of the same table. This addition contributes to the overall reliability and robustness of our software.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +10.11% 🎉

Comparison is base (c5aa0b1) 89.59% compared to head (661a5bf) 99.70%.
Report is 3 commits behind head on master.

Additional details and impacted files

@@              Coverage Diff              @@
##             master     #744       +/-   ##
=============================================
+ Coverage     89.59%   99.70%   +10.11%     
+ Complexity     1375     1269      -106     
=============================================
  Files            67       63        -4     
  Lines          3382     3038      -344     
=============================================
- Hits           3030     3029        -1     
+ Misses          352        9      -343     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[terabytesoftw]

If you are looking at the test now, of course it is a bug.

[Tigrov]

@terabytesoftw

If you are looking at the test now, of course it is a bug.

Or we can mention about this in the doc for these methods:
@param string[] $columns The column names of the table.

Currently it is
@param string[] $columns The column names.

[terabytesoftw]

@terabytesoftw

If you are looking at the test now, of course it is a bug.

Or we can mention about this in the doc for these methods: @param string[] $columns The column names of the table.

Now it is @param string[] $columns The column names.

If that’s all right, let's do it.

[Tigrov]

Solved by #746