Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix psalm issues #288

Merged
merged 8 commits into from
Feb 3, 2024
Merged

Fix psalm issues #288

merged 8 commits into from
Feb 3, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jan 29, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05ebf54) 98.42% compared to head (84dc3de) 98.42%.

❗ Current head 84dc3de differs from pull request most recent head 53a5b06. Consider uploading reports for the commit 53a5b06 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #288   +/-   ##
=========================================
  Coverage     98.42%   98.42%           
  Complexity      329      329           
=========================================
  Files            19       19           
  Lines          1015     1015           
=========================================
  Hits            999      999           
  Misses           16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Jan 29, 2024

PR Summary

  • Updated the createIndex method in DDLQueryBuilder.php

    • This method can now handle situations where the index type and database schema might not be specified. It makes sure that indexes can be created effectively even if some details are not provided.
  • Modification in getJsonColumns method in Schema.php

    • This change affects how we identify textual patterns in a data string (using preg_match_all). It makes sure that we only capture meaningful results by checking if the match count is more than zero.
    • Also, it now ensures that only non-empty matches are added to the results array, thereby reducing unnecessary clutter and improving efficiency.

@Tigrov Tigrov added the status:code review The pull request needs review. label Jan 30, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Sergei Predvoditelev <[email protected]>
@vjik vjik merged commit f0acbe5 into master Feb 3, 2024
3 checks passed
@vjik vjik deleted the fix-psalm-issues branch February 3, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants