Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests according to main PR #277

Closed
wants to merge 1 commit into from

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Oct 26, 2023

Related with yiisoft/db#766

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Oct 26, 2023

PR Summary

  • Inclusion of ColumnInterface class in tests/CommandTest.php
    The class ColumnInterface has been included at the top of the tests/CommandTest.php file, extending the set of available classes used in the tests.
  • Refinement of testAlterColumn method in tests/CommandTest.php
    The previously defined testAlterColumn method has been updated to a new version that accepts two potential parameter types: ColumnInterface or a simple string.
  • Inclusion of ColumnInterface class in tests/QueryBuilderTest.php
    Similarly, the class ColumnInterface is also declared at the start of the tests/QueryBuilderTest.php file, broadening the set of classes that can be used within the file.
  • Refinement of testAlterColumn method in tests/QueryBuilderTest.php
    As with CommandTest.php, QueryBuilderTest.php also now utilizes a new version of the testAlterColumn function. This updated method can also be called with either ColumnInterface or simple string parameters.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6bf147f) 98.47% compared to head (6415f5b) 98.47%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #277   +/-   ##
=========================================
  Coverage     98.47%   98.47%           
  Complexity      343      343           
=========================================
  Files            19       19           
  Lines          1046     1046           
=========================================
  Hits           1030     1030           
  Misses           16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov
Copy link
Member Author

Tigrov commented Oct 26, 2023

Not required

@Tigrov Tigrov closed this Oct 26, 2023
@Tigrov Tigrov deleted the allow-columninterface-as-type branch October 26, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant