Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CTE query expressions #274

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Fix CTE query expressions #274

merged 1 commit into from
Oct 14, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Sep 28, 2023

Update tests according to yiisoft/db#761

@what-the-diff
Copy link

what-the-diff bot commented Sep 28, 2023

PR Summary

  • Improved Code Syntax in QueryBuilderTest
    In the testing file named QueryBuilderTest.php, there was a tricky syntax issue. The alias terms we use for tables, specifically a1 and a2, were creating confusion. To solve this, they were wrapped with special characters called backticks. This small change helps eliminate any uncertainty the computer may have when reading our code. It ensures our tests run as intended, keeping our software reliable.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1b375d2) 98.47% compared to head (b71c6e2) 98.47%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #274   +/-   ##
=========================================
  Coverage     98.47%   98.47%           
  Complexity      343      343           
=========================================
  Files            19       19           
  Lines          1046     1046           
=========================================
  Hits           1030     1030           
  Misses           16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review September 28, 2023 11:15
@Tigrov Tigrov merged commit 6bf147f into yiisoft:master Oct 14, 2023
16 of 17 checks passed
@Tigrov Tigrov deleted the fix-cte branch October 14, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants