Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DateTime instances #269

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Aug 5, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Fixed issues #725

@what-the-diff
Copy link

what-the-diff bot commented Aug 5, 2023

PR Summary

  • Enhanced Functionality for Timezone in ColumnSchema Class
    The ColumnSchema class can now detect if a particular column carries timezone information or not, thanks to the newly added hasTimezone method.

  • Adjustment of Year Column Type in Schema Class
    We've adjusted the data type of the year column in the Schema class, moving it from TYPE_DATE to TYPE_SMALLINT, thereby increasing its efficiency.

  • Support for Additional Column Types in Schema Class
    The Schema class has been updated to support timetz and timestamptz column types, thus expanding the range of data types that can be used for your columns.

  • Improved Handling of Default Values in Schema Class
    We've made modifications to the loadColumnSchema method within the Schema class so it can handle default values for various column types more effectively.

  • Additional Testing for the ColumnSchemaTest and SchemaProvider Classes
    New test cases have been added to the ColumnSchemaTest and SchemaProvider classes. These tests specifically relate to the new column types and default values we've incorporated, ensuring optimal performance and avoiding potential bugs.

  • Updated SQL Fixture File
    The SQL fixture file has been updated to include new columns with varied types and default values. This update enhances testing conditions and ensures that our changes integrate smoothly into existing structures.

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (b172ec9) 98.21% compared to head (d718b0b) 98.22%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #269      +/-   ##
============================================
+ Coverage     98.21%   98.22%   +0.01%     
  Complexity      325      325              
============================================
  Files            17       18       +1     
  Lines          1006     1013       +7     
============================================
+ Hits            988      995       +7     
  Misses           18       18              
Files Changed Coverage Δ
src/ColumnSchema.php 100.00% <100.00%> (ø)
src/Schema.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review August 5, 2023 16:19
@Tigrov Tigrov marked this pull request as draft August 17, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant