Change property Schema::$typeMap to constant Schema::TYPE_MAP (#282)

yiisoft · Nov 16, 2023 · fd45a0b · fd45a0b
1 parent e3d9164
commit fd45a0b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## 1.1.1 under development
 
 - Enh #281: Remove unused code in `Command` class (@vjik)
+- Enh #282: Change property `Schema::$typeMap` to constant `Schema::TYPE_MAP` (@Tigrov)
 
 ## 1.1.0 November 12, 2023
 

diff --git a/src/Schema.php b/src/Schema.php
@@ -72,9 +72,11 @@
 final class Schema extends AbstractPdoSchema
 {
     /**
-     * @var string[] Mapping from physical column types (keys) to abstract column types (values).
+     * Mapping from physical column types (keys) to abstract column types (values).
+     *
+     * @var string[]
      */
-    private array $typeMap = [
+    private const TYPE_MAP = [
         'tinyint' => self::TYPE_TINYINT,
         'bit' => self::TYPE_SMALLINT,
         'boolean' => self::TYPE_BOOLEAN,
@@ -481,8 +483,8 @@ protected function loadColumnSchema(array $info): ColumnSchemaInterface
         if (preg_match('/^(\w+)(?:\(([^)]+)\))?/', $column->getDbType() ?? '', $matches)) {
             $type = strtolower($matches[1]);
 
-            if (isset($this->typeMap[$type])) {
-                $column->type($this->typeMap[$type]);
+            if (isset(self::TYPE_MAP[$type])) {
+                $column->type(self::TYPE_MAP[$type]);
             }
 
             if (!empty($matches[2])) {