Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fixtures according to tests #328

Closed
wants to merge 1 commit into from
Closed

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jan 3, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c003f9c) 100.00% compared to head (5c998c6) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #328   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       187       187           
===========================================
  Files             13        13           
  Lines            566       566           
===========================================
  Hits             566       566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Jan 3, 2024

PR Summary

The primary changes in this PR involve the modification of our database schema as described below. These changes will allow our data to better accommodate future functionalities and make our database structure flexible for inevitable updates.

  • New Columns Added to pgsql.sql
    Three new columns named float_col, char_col, and bool_col have been added. Respectively, these are capable of storing numerical data with decimal points, text data limited to 100 characters, and boolean values (true/false).

  • Positions of Columns Revised
    The placement of some columns within pgsql.sql has been restructured. This is often done to improve the clarity and ease of access, ensuring our database remains sensible and manageable as it grows.

  • Removal of Default Values
    The initial or "default" values for columns bool_col, char_col, and float_col have been eliminated. This alteration provides greater flexibility to our data input process as the fields won't be auto-populated.

  • Modification of Default Values
    Initial values for certain existing columns namely char_col2, float_col2, bool_col2, ts_default, and bit_col have been updated. This can help to better align our data with the evolving requirements of our project.

@Tigrov Tigrov closed this Jan 7, 2024
@Tigrov Tigrov deleted the batchInsert-empty-columns branch January 9, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant