Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move methods from command to abstract pdo command #321

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 5, 2023

Related with yiisoft/db#770

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf03e81) 100.00% compared to head (92302ff) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #321   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       197       187   -10     
===========================================
  Files             13        13           
  Lines            587       566   -21     
===========================================
- Hits             587       566   -21     
Files Coverage Δ
src/Command.php 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Nov 5, 2023

PR Summary

  • File Modifications

    • The Command.php file has undergone several modifications to improve its functionality.
  • Removal of Use Statements

    • Several 'use' statements, including use Exception; and use Throwable;, as well as use Yiisoft\Db\Exception\ConvertException; and use Yiisoft\Db\QueryBuilder\QueryBuilderInterface; have been removed from the file. This might simplify the code and remove unnecessary dependencies.
  • Method Removal

    • The getQueryBuilder() method has been taken out from the Command.php file. This could signify a change in how the query builder is accessed or it might no longer be necessary.
  • Method Modification

    • The internalExecute(string|null $rawSql) method has received a significant overhaul to its declaration and contents. Its declaration is no longer specifying a void return type, indicating that this function might now return a result. Also, changes to the logic within the method may lead to different or enhanced behavior. It's probable that these changes are made to ensure the method is more efficient and flawless.

@Tigrov Tigrov marked this pull request as ready for review November 5, 2023 07:34
@Tigrov Tigrov merged commit 675d297 into master Nov 7, 2023
33 of 34 checks passed
@Tigrov Tigrov deleted the move-methods-from-Command-to-AbstractPdoCommand branch November 7, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants