Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$expression->getType() returns database type but not an abstract type #319

Merged
merged 3 commits into from
Oct 14, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Oct 10, 2023

Related PR: yiisoft/db#765

Q A
Is bugfix? ✔️/❌
New feature?
Breaks BC?
Fixed issues -

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (53d7b0e) 100.00% compared to head (08087e8) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #319   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       200       200           
===========================================
  Files             13        13           
  Lines            594       594           
===========================================
  Hits             594       594           
Files Coverage Δ
src/Builder/ArrayExpressionBuilder.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review October 10, 2023 10:55
@Tigrov Tigrov requested a review from terabytesoftw October 10, 2023 10:55
@Tigrov Tigrov merged commit c467070 into yiisoft:master Oct 14, 2023
31 of 32 checks passed
@Tigrov Tigrov deleted the deprecate_type_jsonb branch October 14, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants