Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DMLQueryBuilder #313

Merged
merged 6 commits into from
Nov 1, 2023
Merged

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Aug 19, 2023

Related with yiisoft/db#746

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues

@what-the-diff
Copy link

what-the-diff bot commented Aug 19, 2023

PR Summary

  • Simplifications in DMLQueryBuilder.php
    The code was streamlined for efficiency. This includes simplifying how variables are assigned, improving error handling, and making the construction of SQL statements more effective.

  • New Test Case in QueryBuilderProvider.php
    A new test case was added to better ensure the reliability of our program. Specifically, this test checks how the program handles unique values that aren't in the first position. This provides better quality assurance moving forward.

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c467070) 100.00% compared to head (08bcd46) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #313   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       200       197    -3     
===========================================
  Files             13        13           
  Lines            594       587    -7     
===========================================
- Hits             594       587    -7     
Files Coverage Δ
src/DMLQueryBuilder.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review August 19, 2023 10:54
src/DMLQueryBuilder.php Show resolved Hide resolved
src/DMLQueryBuilder.php Show resolved Hide resolved
@Tigrov Tigrov merged commit cf03e81 into yiisoft:master Nov 1, 2023
31 of 32 checks passed
@Tigrov Tigrov deleted the refactor_dml_query_builder branch November 1, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants