Improve performance of quoting column names up to 10% using `array_ma…

…p()`
yiisoft · Oct 4, 2023 · 04e6374 · 04e6374
1 parent 380918d
commit 04e6374
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/DMLQueryBuilder.php b/src/DMLQueryBuilder.php
@@ -9,6 +9,7 @@
 use Yiisoft\Db\Query\QueryInterface;
 use Yiisoft\Db\QueryBuilder\AbstractDMLQueryBuilder;
 
+use function array_map;
 use function implode;
 
 /**
@@ -22,11 +23,12 @@ public function insertWithReturningPks(string $table, QueryInterface|array $colu
         $returnColumns = $this->schema->getTableSchema($table)?->getPrimaryKey();
 
         if (!empty($returnColumns)) {
-            $returning = [];
-            foreach ($returnColumns as $name) {
-                $returning[] = $this->quoter->quoteColumnName($name);
-            }
-            $sql .= ' RETURNING ' . implode(', ', $returning);
+            $returnColumns = array_map(
+                [$this->quoter, 'quoteColumnName'],
+                $returnColumns,
+            );
+
+            $sql .= ' RETURNING ' . implode(', ', $returnColumns);
         }
 
         return $sql;