Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change property Schema::$typeMap to constant Schema::TYPE_MAP #248

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 16, 2023

The change reduces size of cache.

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Nov 16, 2023

PR Summary

  • Update of typeMap property in Schema.php
    The property typeMap, used to store different types of data, has been transformed into a constant called TYPE_MAP. This means that its value is now fixed and cannot be changed. Additionally, its visibility has been altered to private, limiting its access to within the Schema.php local context. This ensures internal consistency and reliability in how we track different types of data in our system.

  • Modification in extractColumnType method
    The method extractColumnType, which is used to determine the type of certain data, has been updated to use the newly established TYPE_MAP constant. This means it will now work with the most up-to-date and unchangeable settings for data types, ensuring its results are always consistent with the system's understanding of different data types.

@Tigrov Tigrov added the status:code review The pull request needs review. label Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8797495) 98.40% compared to head (d961d80) 98.40%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #248   +/-   ##
=========================================
  Coverage     98.40%   98.40%           
  Complexity      175      175           
=========================================
  Files            16       16           
  Lines           564      564           
=========================================
  Hits            555      555           
  Misses            9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit ebb4645 into master Nov 16, 2023
18 checks passed
@vjik vjik deleted the change-typemap-to-constant branch November 16, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants