Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BC issues #245

Closed
wants to merge 1 commit into from
Closed

Fix BC issues #245

wants to merge 1 commit into from

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 12, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Nov 12, 2023

PR Summary

  • Introduction of Generator Import
    The code now includes an import statement for Generator. This allows us to use a key tool in handling data streams, which should improve the efficiency of our code.

  • Update to batchInsert Method Signature
    We've updated the way the batchInsert method works: it now accepts either an iterable or a Generator as the parameter type for $rows. This offers more flexibility in the data types we can use with this method, enhancing the functionality and user experience of our software.

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0bd00d) 98.39% compared to head (52671b4) 98.39%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #245   +/-   ##
=========================================
  Coverage     98.39%   98.39%           
  Complexity      174      174           
=========================================
  Files            16       16           
  Lines           561      561           
=========================================
  Hits            552      552           
  Misses            9        9           
Files Coverage Δ
src/DMLQueryBuilder.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik
Copy link
Member

vjik commented Nov 12, 2023

Removing Generator in this case is not break BC. See https://3v4l.org/SENSO

@vjik vjik closed this Nov 12, 2023
@vjik vjik deleted the fix-bc-issues branch November 12, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants