Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move methods from Command to AbstractPDOCmmand class #243

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 5, 2023

Related with yiisoft/db#770

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Nov 5, 2023

PR Summary

  • Removal of the getQueryBuilder() method
    The getQueryBuilder() method was removed from the Command class. This was done because it was not being used.

  • Cleanup of the internalExecute() method
    The internalExecute() method was updated to remove redundant code and exception handling related to transactions and retry logic.

  • Removal of unused import statements
    Several import statements were removed because they were not being used in the current code. These include import statements for PDOException, Throwable, ConvertException, QueryBuilderInterface, QueryBuilder, PDO, SchemaInterface, array_keys, AbstractPdoCommand.

  • Refactoring bindPendingParams() method
    The bindPendingParams() method was updated to remove the $rawSql parameter and associated code to make it more efficient.

  • Modification of showDatabases() method
    The showDatabases() method no longer has a return type declaration. This change was made for better compatibility with different types of databases.

Provided changes aim to clean up the code, remove unnecessary elements, and enhance efficiency. This should provide a cleaner, faster release of this software.

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ecee24) 98.44% compared to head (7cd697b) 98.39%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #243      +/-   ##
============================================
- Coverage     98.44%   98.39%   -0.06%     
+ Complexity      184      174      -10     
============================================
  Files            16       16              
  Lines           580      561      -19     
============================================
- Hits            571      552      -19     
  Misses            9        9              
Files Coverage Δ
src/Command.php 97.91% <ø> (-0.60%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review November 5, 2023 07:34
@Tigrov Tigrov merged commit e0bd00d into master Nov 7, 2023
19 checks passed
@Tigrov Tigrov deleted the move-methods-from-Command-to-AbstractPdoCommand branch November 7, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants