Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix psalm issue (#233) #234

Merged
merged 3 commits into from
Aug 20, 2023
Merged

Fix psalm issue (#233) #234

merged 3 commits into from
Aug 20, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Aug 20, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues #233

@what-the-diff
Copy link

what-the-diff bot commented Aug 20, 2023

PR Summary

  • Refactoring for Improved Readability
    The changes made in the src/Command.php file, specifically on line 136, simplified the code to make it easier to understand. The way we handle certain actions in our program has been converted from a shorter form, known as "lambda notation," to a more traditional and readable format. This has benefits for our team, making the code more maintainable and easier to work with in the future.

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1549c26) 98.29% compared to head (c88dcea) 98.29%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #234   +/-   ##
=========================================
  Coverage     98.29%   98.29%           
  Complexity      186      186           
=========================================
  Files            16       16           
  Lines           585      587    +2     
=========================================
+ Hits            575      577    +2     
  Misses           10       10           
Files Changed Coverage Δ
src/Command.php 98.55% <100.00%> (+0.04%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review August 20, 2023 01:44
@Tigrov Tigrov merged commit c7b4fc2 into yiisoft:master Aug 20, 2023
@Tigrov Tigrov deleted the fix_psalm_issue branch August 20, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants