Support DateTime instances #231
Conversation
PR Summary
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #231 +/- ##
============================================
- Coverage 98.29% 98.21% -0.08%
- Complexity 186 194 +8
============================================
Files 16 16
Lines 585 617 +32
============================================
+ Hits 575 606 +31
- Misses 10 11 +1
☔ View full report in Codecov by Sentry. |
| return parent::phpTypecast($value); | ||
| } | ||
|
|
||
| public function hasTimezone(): bool |
There was a problem hiding this comment.
Need have a tests for public functions
There was a problem hiding this comment.
ColumnSchema::hasTimezone() can be replaced with two new abstract types SchemaInterface::TYPE_TIMESTAMPTZ and SchemaInterface::TYPE_TIMETZ
Tests will be added after review this option in yiisoft/db #736
| parent::initConnection(); | ||
|
|
||
| $this->pdo->exec( | ||
| <<<SQL |
There was a problem hiding this comment.
What benefits in changes settings of db? What about cases with default settings?
This changes can be in documentation only. It's change user experience.
There was a problem hiding this comment.
When getting datetime values from Oracle they are returned in a specific format that is not suitable for proper parsing by DateTime.
Yes, sure it will need to be added to the documentation
Yes, mentioned about this in the description:
|
Support for the
timetype with test coverage will be added after review of #230