Improve

yiisoft · Oct 9, 2024 · 508f947 · 508f947
1 parent 1d46ee6
commit 508f947
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 2 deletions.
diff --git a/src/Column/ColumnDefinitionBuilder.php b/src/Column/ColumnDefinitionBuilder.php
@@ -10,6 +10,7 @@
 
 use function ceil;
 use function log10;
+use function strtoupper;
 
 final class ColumnDefinitionBuilder extends AbstractColumnDefinitionBuilder
 {
@@ -46,6 +47,20 @@ final class ColumnDefinitionBuilder extends AbstractColumnDefinitionBuilder
         'number',
     ];
 
+    protected function buildOnDeleteClause(string $onDelete): string
+    {
+        return match ($onDelete = strtoupper($onDelete)) {
+            'CASCADE',
+            'SET NULL' => " ON DELETE $onDelete",
+            default => '',
+        };
+    }
+
+    protected function buildOnUpdateClause(string $onUpdate): string
+    {
+        return '';
+    }
+
     protected function getDbType(ColumnSchemaInterface $column): string
     {
         $size = $column->getSize();

diff --git a/tests/Provider/QueryBuilderProvider.php b/tests/Provider/QueryBuilderProvider.php
@@ -6,7 +6,9 @@
 
 use Exception;
 use Yiisoft\Db\Constant\PseudoType;
+use Yiisoft\Db\Constraint\ForeignKeyConstraint;
 use Yiisoft\Db\Expression\Expression;
+use Yiisoft\Db\Oracle\Column\ColumnBuilder;
 use Yiisoft\Db\Oracle\Tests\Support\TestTrait;
 use Yiisoft\Db\Query\Query;
 use Yiisoft\Db\Tests\Support\DbHelper;
@@ -239,6 +241,14 @@ public static function upsert(): array
 
     public static function buildColumnDefinition(): array
     {
+        $referenceRestrict = new ForeignKeyConstraint();
+        $referenceRestrict->foreignColumnNames(['id']);
+        $referenceRestrict->foreignTableName('ref_table');
+        $referenceRestrict->onDelete('restrict');
+
+        $referenceSetNull = clone $referenceRestrict;
+        $referenceSetNull->onDelete('set null');
+
         $values = parent::buildColumnDefinition();
 
         $values[PseudoType::PK][0] = 'number(10) GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY';
@@ -319,8 +329,14 @@ public static function buildColumnDefinition(): array
         $values['unsigned()'][0] = 'number(10)';
         $values['scale(2)'][0] = 'number(10,2)';
         $values['integer(8)->scale(2)'][0] = 'number(8)';
-        $values['reference($reference)'][0] = 'number(10) REFERENCES "ref_table" ("id") ON DELETE CASCADE ON UPDATE CASCADE';
+        $values['reference($reference)'][0] = 'number(10) REFERENCES "ref_table" ("id") ON DELETE CASCADE';
+        $values['reference($referenceWithSchema)'][0] = 'number(10) REFERENCES "ref_schema"."ref_table" ("id") ON DELETE CASCADE';
 
-        return $values;
+        return [
+            ...$values,
+
+            ['number(10) REFERENCES "ref_table" ("id")', ColumnBuilder::integer()->reference($referenceRestrict)],
+            ['number(10) REFERENCES "ref_table" ("id") ON DELETE SET NULL', ColumnBuilder::integer()->reference($referenceSetNull)],
+        ];
     }
 }