Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore connection if closed by timeout #349

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Aug 19, 2024

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #348

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (883758a) to head (f36bd3a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #349      +/-   ##
============================================
+ Coverage     98.69%   98.71%   +0.01%     
- Complexity      171      174       +3     
============================================
  Files            15       15              
  Lines           538      546       +8     
============================================
+ Hits            531      539       +8     
  Misses            7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:code review The pull request needs review. label Aug 19, 2024
@Tigrov Tigrov requested a review from a team August 19, 2024 05:11
@samdark samdark changed the title Restore connection if closed by tomeout Restore connection if closed by timeout Aug 19, 2024
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@Tigrov Tigrov merged commit 06226eb into master Aug 23, 2024
30 checks passed
@Tigrov Tigrov deleted the restore-connection-if-closed branch August 23, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants