Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test according to main PR #321

Merged
merged 8 commits into from
Apr 12, 2024
Merged

Update test according to main PR #321

merged 8 commits into from
Apr 12, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Feb 6, 2024

Main PR

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Feb 6, 2024

PR Summary

  • Revamped CommandTest.php
    The testing method for updates in 'CommandTest.php' file has been adjusted to utilize a couple of new parameters – a specified set of values (array $expectedValues) and a count value (int $expectedCount). The cited parameters are replacing an existing one, making the testing process more granular and comprehensive.

  • Adjusted QueryBuilderTest.php
    Our update testing method in 'QueryBuilderTest.php' now also includes a set of specific parameters (array $params) and a specific SQL string (string $expectedSql). These new parameters take the place of the previously implemented ones, honing the testing process, allowing for more targeted and precise testing engagements.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.08%. Comparing base (4f44e1a) to head (a7738ed).
Report is 4 commits behind head on master.

❗ Current head a7738ed differs from pull request most recent head 5a93935. Consider uploading reports for the commit 5a93935 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #321      +/-   ##
============================================
+ Coverage     99.04%   99.08%   +0.04%     
- Complexity      174      183       +9     
============================================
  Files            13       15       +2     
  Lines           524      549      +25     
============================================
+ Hits            519      544      +25     
  Misses            5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need line in changelog

@vjik vjik merged commit df7cf71 into master Apr 12, 2024
2 of 3 checks passed
@vjik vjik deleted the fix-update-with-expressions branch April 12, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants