Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve deprecated methods #318

Merged
merged 5 commits into from
Feb 10, 2024
Merged

Resolve deprecated methods #318

merged 5 commits into from
Feb 10, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jan 29, 2024

Related with

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Jan 29, 2024

PR Summary

  • Enhancement of Schema.php with New Function
    The new array_change_key_case function has been added to Schema.php. This addition helps in transforming the case of keys of an array, providing more flexibility in handling data.

  • Modification of Functions at Specific Lines
    The existing normalizeRowKeyCase function has been replaced with the array_change_key_case function at two spots (line 45 and line 89) of the code. This replacement aims to make our key case transformation uniform across different parts of our project, enabling us to manage our data more efficiently and reducing potential errors that can occur due to case mismatches.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9fae32a) 99.04% compared to head (ceb93df) 99.04%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #318   +/-   ##
=========================================
  Coverage     99.04%   99.04%           
  Complexity      174      174           
=========================================
  Files            13       13           
  Lines           524      524           
=========================================
  Hits            519      519           
  Misses            5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:code review The pull request needs review. label Jan 30, 2024
@Tigrov Tigrov merged commit 72531d4 into master Feb 10, 2024
78 of 82 checks passed
@Tigrov Tigrov deleted the deprecate-schema-methods branch February 10, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants