Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Command::insertWithReturningPks() #314

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Dec 17, 2023

Related PR

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues yiisoft/db#792

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c9a8ce5) 99.04% compared to head (8cc993c) 99.04%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #314   +/-   ##
=========================================
  Coverage     99.04%   99.04%           
  Complexity      174      174           
=========================================
  Files            13       13           
  Lines           524      524           
=========================================
  Hits            519      519           
  Misses            5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Dec 17, 2023

PR Summary

  • Modification in Command.php File
    A new variable named $tableSchema has been introduced in the Command.php file. This variable obtains table schema information from the database, essentially gathering the blueprint of a table's structure and relationship in the database.

  • Condition Status Unchanged
    No alterations were made to the existing condition if (!$this->execute()) within the program's logic. The functionality of this part remains as is, which checks if a particular operation or command executes successfully or not.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Alexey Rogachev <[email protected]>
@vjik vjik merged commit 65497c3 into master Dec 21, 2023
41 of 43 checks passed
@vjik vjik deleted the test-insertWithReturningPks-empty-values branch December 21, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants