Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move methods from command to abstract pdo command #309

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 5, 2023

Related with yiisoft/db#770

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dcb2370) 99.08% compared to head (cdd3762) 99.04%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #309      +/-   ##
============================================
- Coverage     99.08%   99.04%   -0.04%     
+ Complexity      184      174      -10     
============================================
  Files            13       13              
  Lines           545      524      -21     
============================================
- Hits            540      519      -21     
  Misses            5        5              
Files Coverage Δ
src/Command.php 94.73% <ø> (-2.77%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Nov 5, 2023

PR Summary

  • Modification in Command.php File
    The main file operating the command functionalities has undergone some amendments.

  • Removal of Certain use Statements
    Four classes, namely PDOException, Throwable, ConvertException, and QueryBuilderInterface were removed. This indicates a possible cleanup or refactored usage of these classes within the code.

  • Removal of getQueryBuilder() Method
    The function used to get the query builder has been erased. This suggests changes in the way queries are being made within the system.

  • Changes in internalExecute() Method
    This method is responsible for executing queries and handling exceptions. There have been modifications in this logic which implies the system has changed the way it handles database query executions and the potential errors that may arise.

  • No changes to showDatabases() Method
    This method used to display the databases remains unchanged, indicating no alterations in the way databases are being displayed.

@Tigrov Tigrov marked this pull request as ready for review November 5, 2023 07:34
@Tigrov Tigrov merged commit a289698 into master Nov 7, 2023
43 checks passed
@Tigrov Tigrov deleted the move-methods-from-Command-to-AbstractPdoCommand branch November 7, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants